Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guests can see reply button in forum, resulting in 404 after posting #326

Closed
jerone opened this issue Aug 25, 2014 · 2 comments · Fixed by #451
Closed

Guests can see reply button in forum, resulting in 404 after posting #326

jerone opened this issue Aug 25, 2014 · 2 comments · Fixed by #451
Labels
bug You've guessed it... this means a bug is reported. needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. UI Pertains inclusively to the User Interface.

Comments

@jerone
Copy link
Contributor

jerone commented Aug 25, 2014

Steps to reproduce:

  1. Log out
  2. Go to forum post (e.g. https://openuserjs.org/announcements/Welcome!!!)
  3. Press "Reply" button
  4. Type something
  5. Press other "Reply" button
  6. See 404 page

Two solutions:

  1. We hide/disable the "Reply" button for guests. Easy and fast.
  2. We link the "Reply" button to the login page for guests. A little harder, because guests won't automatic return to the discussion again after logging in.
@jerone jerone self-assigned this Aug 25, 2014
@Martii
Copy link
Member

Martii commented Aug 25, 2014

Try this.

  1. Two tabs (or windows) on our site
  2. Log into one
  3. Go reply in the other.

This is the only use case where I can think of that executing that existing routine with the reply buttons/box is useful.

We link the "Reply" button to the login page for guests. A little harder, because guests won't automatic return to the discussion again after logging in.

That would definitely be a more graceful failure (#37). :)

@jerone
Copy link
Contributor Author

jerone commented Aug 25, 2014

  • We link the "Reply" button to the login page for guests. A little harder, because guests won't automatic return to the discussion again after logging in.

After looking at it for a second time this may currently not be the user friendly solution. Altering the "Reply" button beside each existing comments to redirect to the login page shouldn't be hard. The problem lies when you scroll down the page and the reply textarea opens up. People will probably start typing before noting that they can't reply (or losing the text after pressing the reply button, resulting in a 404).
I'm looking into docs to get that textarea & corresponding buttons to disable and show another message that shows the user to sign in.

@jerone jerone removed their assignment Oct 9, 2014
@jerone jerone self-assigned this Nov 26, 2014
Martii added a commit that referenced this issue Dec 1, 2014
Disable reply buttons for guests. Fixes #326

merge
@jerone jerone removed their assignment Dec 1, 2014
@OpenUserJS OpenUserJS deleted a comment from svishal Oct 12, 2018
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. UI Pertains inclusively to the User Interface.
Development

Successfully merging a pull request may close this issue.

2 participants