Disable reply buttons for guests. Fixes #326 #451
Conversation
jerone
added
PR READY
|
Suggestion... try at least these urls logged out and look for green buttons (this list could grow):
... It would be super cool to have some symmetry across the board with that not just replies (avoid vote/flag/remove though... that can be done later after we stop keeping sizzle from remerging/modifying his stuff and my keeping him busy with the production issues) ... the little popup is very kewl. :) |
What do you mean by this?
This was going to be my next PR. |
|
You sort of answered your own question here by telling me it's your next PR... basically that PR should be present before this gets merged in order to show that symmetry is happening... I'll be supporting this whichever methodology you choose from above... although it would be nice to have a QSP to take it back to where a user was including any sub QSP e.g. if a user is on a QSP'd item the login page redirects back to that QSP'd URI... something USO didn't do. |
|
What does QSP mean? |
|
My apologies... been using this acronym terminology on USO since around 2005 and definitely before that. http://www.wikipedia.org/wiki/Query_string QS === Query String |
…into issue-326 Conflicts: views/pages/scriptIssuePage.html
|
Tooltips at http://localhost:8080/users/Marti/comments don't appear to be styled the same as http://localhost:8080/discuss/Test_1 |
| {{^authedUser}} | ||
| <script> | ||
| $(function () { | ||
| $('.btn-comment-reply').parent().tooltip().click(function(){ |
There was a problem hiding this comment.
function(){
Should be function () {
|
Head style diff shows: <link href="/redist/npm/bootstrap-markdown/css/bootstrap-markdown.min.css" media="all" type="text/css" rel="stylesheet">... present on http://localhost:8080/discuss/Test_1 but not on http://localhost:8080/users/Marti/comments |
|
@Martii commented on 1 dec. 2014 21:54 CET:
Actually reply buttons shouldn't be there at all. There's even no logic attached to it. Please open another issue for this. |
I know... I think Zren/sizzle thought maybe having a redirect to login/discussion and come back to it... so it's up to you what you want to do. |
|
@Martii commented on 1 dec. 2014 22:10 CET:
I don't think its useful to start a conversation on that page. A link back to that discussion is sufficient. To me it makes more sense that that button should be hidden. Edited. |
Concur.
Concur... so what do you want to do with this issue/pr then?... mitigation, or new issue, or fix it since it's probably small fix and is partially related to the disabling the reply button for guests. |
|
@Martii commented on 1 dec. 2014 22:23 CET:
New issue. It's a small style issue, but it requires logic in the controllers to hide the button only on that page, as |
|
Mitigation is me... new issue is you please... they more or less mean the same thing but from a different aspect... other than that +1 here and... New refs |
Disable reply buttons for guests. Fixes #326 merge
Martii
added
needs mitigation
Martii
removed
the
PR READY
Fixes #326
This will disable all reply buttons in the forum and script issues pages for guests that are not logged in.
A tooltip will be shown on hover and on click, saying that user needs to login to post.
The reply textbox (which shows up when scrolling down) is also removed when not logged in.