Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed hash function in preprocessing to be consistent with voxel map hash #341

Merged

Conversation

kulfer80
Copy link
Contributor

Hello, I would like to pinpoint small "bug". Hash function in preprocessing isn't consistent with voxel map hash.


This shouldn't change behavior of pipeline but could potentionally improve the speed a little. Hash function should have been made of prime numbers, where 19349663 isn't prime. This PR should fix it.
Thanks for your hard work and your willingness to improve this open source project every day 👌.

Copy link
Collaborator

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👏 thanks for finding this

@nachovizzo
Copy link
Collaborator

@tizianoGuadagnino good to merge?

@tizianoGuadagnino tizianoGuadagnino merged commit 74ea742 into PRBonn:main Jun 13, 2024
17 checks passed
@nachovizzo nachovizzo added the voxelization All the topic related to voxelization utilities label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core voxelization All the topic related to voxelization utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants