Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine FLAGS approval #35904

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 22, 2021

PR types

Others

PR changes

Others

Describe

优化FLAGS approve条件。预测的单测有些场景只会定义一些单测里采用的FLAGS。如#35890 。这些FLAGS不需要暴露在Python。

只有通过PADDLE_DEFINE_EXPORTED_xxx定义的FLAGS,以及修改了python/paddle/fluid/__init__.py文件的FLAGS才需要approve。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sneaxiy sneaxiy requested a review from zhiqiu September 22, 2021 07:25
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 7ba6924 into PaddlePaddle:develop Sep 22, 2021
@sneaxiy sneaxiy deleted the refine_flags_approval branch September 22, 2021 07:31
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Sep 24, 2021
@luckykang
Copy link

【队名】:01战队

【序号】:85

【状态】:报名

【链接】:#35904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants