Add momentum operator #4571
Merged
Add momentum operator #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Oct 4, 2017
paddle/operators/momentum_op.h
Outdated
| auto p = EigenVector<T>::Flatten(*ctx.Input<Tensor>("Param")); | ||
| auto g = EigenVector<T>::Flatten(*ctx.Input<Tensor>("Grad")); | ||
| auto v = EigenVector<T>::Flatten(*ctx.Input<Tensor>("Velocity")); | ||
| float lr = ctx.Input<Tensor>("LearningRate")->data<float>()[0]; |
There was a problem hiding this comment.
That might be not good for GPU. If the LearningRate is in GPU memory, we cannot get float directly.
There was a problem hiding this comment.
Fixed as per #4598
sidgoyal78
requested review from
dzhwinter
and removed request for
abhinavarora
dzhwinter
approved these changes
Oct 18, 2017
| class MomentumOpKernel : public framework::OpKernel<T> { | ||
| public: | ||
| void Compute(const framework::ExecutionContext& ctx) const override { | ||
| auto param_out = ctx.Output<framework::Tensor>("ParamOut"); |
There was a problem hiding this comment.
These parameters will be better if can be named with an auto * to indicate the real type.
|
Thanks for this PR! @sidgoyal78 . Since our book chapters heavily depend on these optimizer operators, so merge this PR ASAP. We can leave the name style unified work in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of momentum operator.
In summary, we want to perform the update with a new velocity vector, such that,
(where mu is the momentum coefficient).