-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use EigenVector to get learning_rate for GPU device in SGD operator #4598
use EigenVector to get learning_rate for GPU device in SGD operator #4598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
paddle/operators/sgd_op.h
Outdated
@@ -23,6 +23,9 @@ using Tensor = framework::Tensor; | |||
template <typename T, int MajorType = Eigen::RowMajor, | |||
typename IndexType = Eigen::DenseIndex> | |||
using EigenVector = framework::EigenVector<T, MajorType, IndexType>; | |||
template <typename T, int MajorType = Eigen::RowMajor, | |||
typename IndexType = Eigen::DenseIndex> | |||
using EigenScalar = framework::EigenScalar<T, MajorType, IndexType>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we should not add type alias in headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix: #4601