Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.8】add hypot rfc #626

Merged
merged 4 commits into from
Sep 15, 2023
Merged

【Hackathon No.8】add hypot rfc #626

merged 4 commits into from
Sep 15, 2023

Conversation

llyyxx0413
Copy link
Contributor

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Sep 14, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@Ligoml Ligoml mentioned this pull request Sep 14, 2023
Open
@lxd-cumt lxd-cumt self-requested a review September 15, 2023 03:20
lxd-cumt
lxd-cumt reviewed Sep 15, 2023
View reviewed changes
Copy link

@lxd-cumt lxd-cumt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

标题编号有小问题，其余正确。

rfcs/APIs/20230914_api_design_for_hypot.md Outdated
```


## 3. Pytorch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

标号错误

2. Pytorch

@lxd-cumt lxd-cumt self-requested a review September 15, 2023 03:25
lxd-cumt
lxd-cumt reviewed Sep 15, 2023
View reviewed changes
Copy link

@lxd-cumt lxd-cumt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC无问题，可以通过

luotao1
luotao1 reviewed Sep 15, 2023
View reviewed changes
rfcs/APIs/20230914_api_design_for_hypot.md Outdated

<!-- 参考：[飞桨API 设计及命名规范](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/api_contributing_guides/api_design_guidelines_standard_cn.html) -->

API设计为 `paddle.hypot(x, y, name)`。其中，`x`, `y` 为 `Tensor` 类型，是直角三角形的边，``paddle.hypot_(x)` 为 inplace 版本。`Tensor.hypot(p)` 为 Tensor 的方法版本。`Tensor.hypot_(x)` 为 Tensor 的 方法 inplace 版本。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 这里有些代码格式问题需要修复

@luotao1 luotao1 merged commit 48a0a2e into PaddlePaddle:master Sep 15, 2023
1 check passed
@luotao1 luotao1 mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxd-cumt lxd-cumt lxd-cumt left review comments

@luotao1 luotao1 luotao1 approved these changes

Assignees

@luotao1 luotao1

@lxd-cumt lxd-cumt

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llyyxx0413 @luotao1 @lxd-cumt