Make MME and DirectSound wait forever for the streaming thread to exit #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PortAudio#919 for rationale. Note that the previous Pa_StopStream() uses a bounded timeout to abort the stream if it doesn't stop within the alloted time, and then another bounded timeout to wait for the streaming thread to exit. This commit preserves the first timeout as it makes sense and appears to be safe, but gets rid of the second one so that we wait indefinitely for the streaming thread to exit.
See PortAudio#919 for rationale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposal described in #919 for MME and DirectSound.