Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MME and DirectSound wait forever for the streaming thread to exit #920

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make MME and DirectSound wait forever for the streaming thread to exit #920

wants to merge 2 commits into from

Commits on Jun 2, 2024

  1. Make MME wait forever for the thread to exit 

    See PortAudio#919 for rationale.

Note that the previous Pa_StopStream() uses a bounded timeout to abort
the stream if it doesn't stop within the alloted time, and then another
bounded timeout to wait for the streaming thread to exit. This commit
preserves the first timeout as it makes sense and appears to be safe,
but gets rid of the second one so that we wait indefinitely for the
streaming thread to exit.
    @dechamps
    dechamps committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    5782ced View commit details
    Browse the repository at this point in the history

  2. Make DirectSound wait forever for the thread to exit 

    See PortAudio#919 for rationale.
    @dechamps
    dechamps committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    148b6a3 View commit details
    Browse the repository at this point in the history