Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: plural props #1536

Closed
wants to merge 5 commits into from
Closed

Ref: plural props #1536

wants to merge 5 commits into from

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Feb 1, 2024 •
edited
Loading

Based on discussion #1193 (reply in thread) .

Choosing the plural version over the singular in order to imply that arrays are acceptable.

@RobinTail RobinTail added refactoring The better way to achieve the same result breaking Backward incompatible changes labels Feb 1, 2024
@RobinTail RobinTail added this to the v17 milestone Feb 1, 2024
@RobinTail RobinTail mentioned this pull request Feb 1, 2024
Merged
@RobinTail RobinTail added the documentation Improvements or additions to documentation label Feb 1, 2024
@RobinTail
Copy link
Owner Author

Need to express NormalizedReponse through ApiResponse

Error: quick-start.ts(21,14): error TS4023: Exported variable 'helloWorldEndpoint' has or is using name 'NormalizedResponse' from external module "/home/runner/work/express-zod-api/express-zod-api/dist/index" but cannot be named.

@RobinTail
Copy link
Owner Author

more harm than good

@RobinTail RobinTail closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Backward incompatible changes documentation Improvements or additions to documentation refactoring The better way to achieve the same result
Projects
None yet
Milestone
v17
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail