Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Multicorn dead? #271

Open
frafra opened this issue Nov 16, 2021 · 19 comments
Open

Is Multicorn dead? #271

frafra opened this issue Nov 16, 2021 · 19 comments

Comments

@frafra
Copy link

frafra commented Nov 16, 2021

Hi,
There hasn't been any kind of code activity for more than one year, and bugs are left open. It seems to me that investing time in developing FDW based on multicorn is useless, if multicorn is not maintained and buggy.

@rdunklau seems to have been the latest committer and works on other projects for Aiven, so it could be that is company is not interested in maintaining this software any more, and he is not willing to or not have enough time to work on that.
The other developers abandoned the projects many years ago.

Should https://github.com/pgsql-io/Multicorn/ by @df7cb be considered the future of multicorn, with some kind of redirect? Should we open PR and issue there?

@df7cb
Copy link
Contributor

df7cb commented Nov 16, 2021

@frafra: Note that https://github.com/pgsql-io/Multicorn/ just happened to merge #260, it's not "my" fork. They sneakily dropped the "WIP" marker on that commit (without actually fixing the issues with it I guess), which might speak about the state of that fork as well.

@frafra
Copy link
Author

frafra commented Nov 16, 2021

@df7cb Sorry for the confusion, and thank you for having clarified that.

@df7cb
Copy link
Contributor

df7cb commented Nov 25, 2021

I've spent some hours looking at this. I now believe #260 to support PG 13 is actually correct and should be merged.

But.

  • PG14 is a lot more complicated. See WIP: Support PostgreSQL 14 #272.
  • PG14 moved the internal numbers for error levels around, which unfortunately means the compiled python module isn't compatible with all PostgreSQL versions anymore (i.e. needs to be compiled for each PG major separately). That means at least the Debian packages need major reshuffling (and will likely not be co-installable anymore, which is major trouble when upgrading PG versions), or Multicorn finds a way to fix that somehow.

@df7cb
Copy link
Contributor

df7cb commented Nov 25, 2021

Fwiw, I am seriously considering to drop Multicorn from both Debian and apt.postgresql.org, the package has accumulated enough cruft by now.

https://bugs.debian.org/1000589

@df7cb
Copy link
Contributor

df7cb commented Dec 6, 2021

I will drop the Multicorn packages now.

@luss
Copy link

luss commented Jan 27, 2022

Hi Guys,

There is nothing sneaky or sinister about the pgsql-io fork of Multicorn (https://github.com/pgsql-io/Multicorn). My need, at the time, was for Multicorn to support PG13. Patch #260 seemed to do that so I merged it into my fork and tagged it as v1.4.1 in my fork so I could easily use it. Multicorn is kewl and I don't want it to die.

--Luss

@denishpatel
Copy link

@luss Any chance you could able to make Multicorn work with Postgres 14? I tried https://github.com/pgsql-io/Multicorn but getting error during make.

@frafra
Copy link
Author

frafra commented Apr 4, 2022

The company behind multicorn is no more: https://opencorporates.com/companies/us_ca/C4537003
If no one picks it up, it can be declared dead, as well as all the code depending on it.

@luss
Copy link

luss commented Apr 4, 2022 via email

@frafra
Copy link
Author

frafra commented Apr 4, 2022

Thanks @luss. Your repository is a bit behind the current master, and it is not possible to open issues there at the moment. I am comfortable using the current repository, but I wonder if you wouldn't prefer to share the burden of maintaining such software with others. Upgrading can be trivial, but there are various PR waiting to be evaluated/merged, potential improvements and some segfaults. I am no Postgres expert, but if there is a small group of people interested in supporting multicorn, I would be glad to help, as it can be such a nice piece of software.

@luss
Copy link

luss commented Apr 4, 2022 via email

@luss
Copy link

luss commented Apr 4, 2022 via email

@denishpatel
Copy link

denishpatel commented Apr 4, 2022

Thanks, @luss ! You had wrong link. Here is the correct link Link

@luss
Copy link

luss commented Apr 5, 2022 via email

@luss
Copy link

luss commented Apr 5, 2022

Tonight I worked on the code a bit in https://github.com/pgsql-io/multicorn. The code in the master branch now compiles (and probably runs) on PG14 (and still compile and runs on PG10 thru PG13. Later this week I'll do some testing. Who wants get to get involved?

@frafra
Copy link
Author

frafra commented Apr 5, 2022

I might help with CI/tests and/or with Python code, but I do not think I can help much with Postgres specifics in the short term.

@luss
Copy link

luss commented Apr 5, 2022 via email

@denishpatel
Copy link

denishpatel commented Apr 5, 2022

Tonight I worked on the code a bit in https://github.com/pgsql-io/multicorn. The code in the master branch now compiles (and probably runs) on PG14 (and still compile and runs on PG10 thru PG13. Later this week I'll do some testing. Who wants get to get involved?

See pgsql-io/multicorn2#4

@luss
Copy link

luss commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants