-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support PostgreSQL 14 #272
base: master
Are you sure you want to change the base?
Conversation
PG14 reworked the FDW interface. This patch is an incomplete attempt to follow the changes. TODO: * multicornBeginForeignScan: extractRestrictions needs access to PlannerInfo *root * multicornBeginForeignModify: This diff needs verification: - PlanState *ps = mtstate->mt_plans[subplan_index]; + PlanState *ps = +#if PG_VERSION_NUM >= 140000 + outerPlanState(mtstate);
Hi @df7cb, I've got last week permissions to merge in this repository, and will review it today/tomorrow. I've merged CI/CD and Windows build yesterday. It still has some small issues, that I need to fix there, and then will look into Your PR. |
@df7cb I'd like to try to help you get this unblocked. Looking first at the issue with
Assuming that is correct, I see this clue from the PG14 docs on
So, although (I'm not familiar with the |
@ShaheedHaque: I have no plans to work on this. If you are interested in getting it fixed, please don't hesitate do jump ahead. |
OK. I did chase things down a bit, and it seems that there is no way for the PlannerInfo to be serialised into the List (by |
@df7cb @ShaheedHaque I'm facing same issue to build it with pg14. anyone of you got success building package with pg14? |
Sadly no.
…On Tue, 22 Mar 2022, 12:53 Denish Patel, ***@***.***> wrote:
@df7cb <https://github.com/df7cb> @ShaheedHaque
<https://github.com/ShaheedHaque> I'm facing same issue to build it with
pg14. anyone of you got success building package with pg14?
—
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFHWKORKD5CWMSQEX4SK33VBG7GPANCNFSM5IYM3HQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There are issues that need resolving, see the last commit message.