feat(Button): add floated prop to Button.Group
#1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.90% (diff: 100%)@@ master #1246 diff @@
==========================================
Files 880 881 +1
Lines 4901 4904 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4700 4703 +3
Misses 201 201
Partials 0 0
|
levithomason
requested changes
Jan 29, 2017
| @@ -10,6 +10,7 @@ describe('ButtonGroup', () => { | |||
| common.implementsWidthProp(ButtonGroup, { propKey: 'widths', widthClass: 'buttons', canEqual: false }) | |||
|
|
|||
| common.propKeyAndValueToClassName(ButtonGroup, 'attached') | |||
| common.propKeyAndValueToClassName(ButtonGroup, 'float') | |||
|
Thanks for the PR. It would be fantastic to get a doc example for this prop as well! |
mohammedkhadar
force-pushed
the
master
branch
from
fed6f77
to
e07212f
Compare
mohammedkhadar
force-pushed
the
master
branch
from
ac209b6
to
6e15ca3
Compare
|
Thanks much! |
|
We forget typings there, I'll make PR soon. |
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
* feat(Button): add `floated` prop to Button.Group * docs(Button): add example for `floated` Button.Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1245