fix(Button): add floated to typings of ButtonGroup
#1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.90% (diff: 100%)@@ master #1248 diff @@
==========================================
Files 881 881
Lines 4904 4904
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4703 4703
Misses 201 201
Partials 0 0
|
|
Thanks again. Would be great to get a smoke test for this so that we aren't missing props between the two. I keep forgetting to update typings. We could assert the interface for every component has props for every propType key. |
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1246 added prop, but typings were not done there.