Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(Dropdown): correct onSearchChange signature #2102

Merged
merged 1 commit into from
Sep 23, 2017

Conversation

layershifter
Copy link
Member

BREAKING

Fixes #2052.
Rel #1828.

Handler Previous Signature Current Signature
onSearchChange (e, value) (e, { ...props, searchQuery })

Before

<Dropdown onSearchChange={(e, value) => console.log(e, value)} />

After

<Dropdown onSearchChange={(e, data) => console.log(e, data.searchQuery)} />

@codecov-io
Copy link

Codecov Report

Merging #2102 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         149      149           
  Lines        2598     2598           
=======================================
  Hits         2592     2592           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2fc8f5...12082e1. Read the comment docs.

@levithomason levithomason merged commit 6d472c6 into master Sep 23, 2017
@levithomason levithomason deleted the fix/dropdown-onsearch branch September 23, 2017 17:28
@levithomason
Copy link
Member

Released in semantic-ui-react@0.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants