feat(Dropdown): add searchQuery prop
#2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should merge #2102 before and update the docs example there. |
Codecov Report
@@ Coverage Diff @@
## master #2109 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 149 149
Lines 2601 2601
=======================================
Hits 2595 2595
Misses 6 6
Continue to review full report at Codecov.
|
|
I will fix merge conflict now |
…React into feat/dropdown-searchquery # Conflicts: # src/modules/Dropdown/Dropdown.js
This was referenced Sep 23, 2017
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1829.
Rel #2048.
This PR allows to control the
searchQueryvia autocontrolled prop, now it has same behaviour as thevalueprop.Adds new tests and example.