Cleanup dependencies #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonMarquis
force-pushed
the
fix/1161-2
branch
from
5c6e593
to
e914843
Compare
This is a followup cleanup of android#1163 that was partially addressed by android#1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
SimonMarquis
force-pushed
the
fix/1161-2
branch
from
e914843
to
930e061
Compare
Using latest graphviz 10.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup cleanup of android#1163 that was partially addressed by android#1140.
projects.core.testingdependencies (or replace with direct dependencies).androidx.compose.ui.testbundle.NiaTestRunnerfrom the default config, forcing consumers to depend on it, even when not used.Here is the current diff on the generated instrumented test APKs (
assembleDemoDebugAndroidTest):find . -name "*.apk" -exec du --human-readable --summarize '{}' \; - 1.6M ./app/build/outputs/apk/androidTest/demo/debug/app-demo-debug-androidTest.apk + 1.2M ./app/build/outputs/apk/androidTest/demo/debug/app-demo-debug-androidTest.apk - 19M ./core/database/build/outputs/apk/androidTest/demo/debug/database-demo-debug-androidTest.apk + 3.9M ./core/database/build/outputs/apk/androidTest/demo/debug/database-demo-debug-androidTest.apk - 20M ./core/designsystem/build/outputs/apk/androidTest/demo/debug/designsystem-demo-debug-androidTest.apk + 18M ./core/designsystem/build/outputs/apk/androidTest/demo/debug/designsystem-demo-debug-androidTest.apk 20M ./core/ui/build/outputs/apk/androidTest/demo/debug/ui-demo-debug-androidTest.apk 20M ./feature/bookmarks/build/outputs/apk/androidTest/demo/debug/bookmarks-demo-debug-androidTest.apk 20M ./feature/foryou/build/outputs/apk/androidTest/demo/debug/foryou-demo-debug-androidTest.apk 20M ./feature/interests/build/outputs/apk/androidTest/demo/debug/interests-demo-debug-androidTest.apk 20M ./feature/search/build/outputs/apk/androidTest/demo/debug/search-demo-debug-androidTest.apk 21M ./feature/settings/build/outputs/apk/androidTest/demo/debug/settings-demo-debug-androidTest.apk 20M ./feature/topic/build/outputs/apk/androidTest/demo/debug/topic-demo-debug-androidTest.apk - 20M ./sync/work/build/outputs/apk/androidTest/demo/debug/work-demo-debug-androidTest.apk + 11M ./sync/work/build/outputs/apk/androidTest/demo/debug/work-demo-debug-androidTest.apk