Extract Roborazzi utils into :roborazzi module
#1163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And cleanup unnecessary transitive dependencies. Fixes android#1161
3 tasks
And remove the `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
|
@dturner this PR is ready to be reviewed 🙇 |
|
Sorry for the delay on reviewing this. Looks good. Any chance you could resolve the merge conflicts @SimonMarquis? |
|
Unfortunately, #1140 changed a lot of unrelated stuff, which makes this hard to rebase/merge. |
SimonMarquis
added a commit
to SimonMarquis/nowinandroid
that referenced
this pull request
Mar 21, 2024
This is a followup cleanup of android#1163 that was partially addressed by android#1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
SimonMarquis
added a commit
to SimonMarquis/nowinandroid
that referenced
this pull request
Mar 21, 2024
This is a followup cleanup of android#1163 that was partially addressed by android#1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
SimonMarquis
added a commit
to SimonMarquis/nowinandroid
that referenced
this pull request
Mar 21, 2024
This is a followup cleanup of android#1163 that was partially addressed by android#1140. - Remove unused `projects.core.testing` dependencies (or replace with direct dependencies). - Introduce `androidx.compose.ui.test` bundle. - Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
Merged
|
@dturner, the updated review can be found here: I'm closing this outdated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And cleanup unnecessary transitive dependencies.
Fixes #1161 (checkout for more details)