Cannot connect SonarLint to SonarQube in 6.7.0.52071 (#3251)

SonarSource · Sep 23, 2022 · 0d4206b · 0d4206b
1 parent 7e515de
commit 0d4206b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/Infrastructure.VS.UnitTests/LanguageDetection/SonarLanguageRecognizerTests.cs b/src/Infrastructure.VS.UnitTests/LanguageDetection/SonarLanguageRecognizerTests.cs
@@ -215,6 +215,7 @@ public void GetAnalysisLanguageFromExtension_ReturnsAnalysisLangFromExtension(st
 
         [DataRow("File.json")]
         [DataRow("Folder")]
+        [DataRow("<SharedProject>")] //Shared projects in .Net Framework are represented by <>
         [TestMethod]
         public void GetAnalysisLanguageFromExtension_UnknownExtensionPassed_ReturnsNull(string fileName)
         {

diff --git a/src/Infrastructure.VS/LanguageDetection/SonarLanguageRecognizer.cs b/src/Infrastructure.VS/LanguageDetection/SonarLanguageRecognizer.cs
@@ -122,6 +122,11 @@ private static bool IsTypeScriptDocument(IEnumerable<IContentType> contentTypes)
 
         public AnalysisLanguage? GetAnalysisLanguageFromExtension(string fileName)
         {
+            if(IsFileNameInvalid(fileName))
+            {
+                return null;
+            }
+
             var extension = GetNormalizedExtention(fileName);
 
             // ContentType for "js" is typescript we do manual check to be consistent with Detect method
@@ -154,6 +159,7 @@ private string GetNormalizedExtention(string fileName)
             return extension.ToLowerInvariant();
         }
 
-
-    }
+        private bool IsFileNameInvalid(string fileName) 
+            => Path.GetInvalidFileNameChars().Any(x => fileName.Contains(x));
+    }  
 }