Cannot connect SonarLint to SonarQube in 6.7.0.52071 #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugras-ergun-sonarsource
changed the title
ugras-ergun-sonarsource
requested review from
rita-gorokhod and
duncanp-sonar
| @@ -154,6 +159,16 @@ private string GetNormalizedExtention(string fileName) | |||
| return extension.ToLowerInvariant(); | |||
| } | |||
|
|
|||
|
|
|||
| private bool IsFileNameInvalid(string fileName) | |||
There was a problem hiding this comment.
I think it's better to do a try-catch around GetNormalizedExtention
There was a problem hiding this comment.
I don't think it's a concern for us. Our code will always run on a windows machine. This would create problems if we had operations run on different systems.
duncanp-sonar
approved these changes
Sep 2, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3219