Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/#162 NaYeonQA #164

Merged
merged 14 commits into from
Sep 22, 2022
Merged

feat/#162 NaYeonQA #164

merged 14 commits into from
Sep 22, 2022

Conversation

NYeonK
Copy link
Contributor

@NYeonK NYeonK commented Sep 18, 2022

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • BestPiickle 마지막에 있는 빈 공백을 최대한 줄였습니다. react-slick으로 없앨 수 없길래, 야매로 해보았습니다.^ㅎ^
  • 회원가입 시, 프로필이 없다면 MyPage 및 MenuBar에서 기본이미지가 떠야하는 데, alt 값이 떠서 해결했습니다.
  • 닉네임에 특수문자와 공백이 안들어가도록 코드를 추가했습니다. (+ 닉네임 수정 시에도!!)

📌 내가 알게 된 부분


📌 질문할 부분


📸 스크린샷

  • 변경 전

  • 변경 후

@NYeonK NYeonK self-assigned this Sep 18, 2022
@NYeonK NYeonK added this to the 💚 Release on August 💚 milestone Sep 18, 2022
@NYeonK NYeonK linked an issue Sep 18, 2022 that may be closed by this pull request
6 tasks
@NYeonK NYeonK changed the title [ fix ] BestPiickle 빈 공백 줄이기 feat/#162 NaYeonQA Sep 18, 2022
@NYeonK NYeonK marked this pull request as draft September 18, 2022 17:40
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫⚡나여니가💫⚡세상을💫⚡구한다💫⚡

Comment on lines +15 to +22
margin-left: -13.5rem;
padding: 0.4rem 1.6rem;
}

& .slick-initialized {
overflow: hidden;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

센터 모드로 해놓고 왼쪽으로 좀 옮겨논거구나????? 천재 아녀?????????

& .slick-initialized {
   overflow: hidden;
 }

는 어떤 동작을 하나요??!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하 역시 오빠는 바로 알아보는구나?😏👍👍👍
margin 값으로 움직였더니 pc 상에서는 서비스 화면을 벗어나길래 추가했습니다!

Comment on lines 52 to 55
<St.ProfileImage
src={userProfile.data.profileImageUrl !== "test" ? userProfile.data.profileImageUrl : ImgDefaultProfile}
alt="프로필"
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!===== 으로 하구 순서를 바꾸는 게 더 읽기 편하지 않을까 싶오요!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구우웃 반영하겠숩니다><

@NYeonK NYeonK marked this pull request as ready for review September 20, 2022 15:17
@NYeonK NYeonK requested a review from NaveOWO September 20, 2022 15:18
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자란다🔥🔥🔥🔥

Comment on lines +29 to +34
const checkSpaceBar = (e: React.KeyboardEvent<HTMLInputElement>) => {
if (e.key === " ") {
e.preventDefault();
return false;
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 입력할 때 말고 valid 확인할 때 확인하지는 못하는 건가요??!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vaild 확인은 닉네임 중복 확인 버튼 눌렀을 때 하는건데,
기획에서 공백이랑 8글자 이상 치는 거는 입력할 때부터 막아달라고 했습니당!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이벤트를 두 개로 두지 않고
onChange에서 확인할 때 확인하면 어떨까 해봤습니다!
편한대로 진행해주십셔!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 event 타입이 달라서 나누었는데, onChange에서 확인하려면, 인자 두개로 받아서 하나요?!

Comment on lines +35 to +41
const checkSpaceBar = (e: React.KeyboardEvent<HTMLInputElement>) => {
if (e.key === " ") {
e.preventDefault();
return false;
}
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 입력할 때 말고 valid 확인할 때 확인하지는 못하는 건가요??!

@joohaem joohaem merged commit c752062 into develop Sep 22, 2022
@joohaem joohaem deleted the feat/#162-NaYeonQA branch December 18, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Common ] (1차) QA - 나연
2 participants