Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/#162 NaYeonQA #164

Merged
merged 14 commits into from
Sep 22, 2022
Merged

feat/#162 NaYeonQA #164

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0d6098a
[ fix ] BestPiickle 빈 공백 줄이기
NYeonK Sep 17, 2022
14935de
[ refactor ] px -> rem 단위 변경
NYeonK Sep 18, 2022
fc18e72
[ design ] 불필요한 style 제거
NYeonK Sep 18, 2022
57e9c03
[ fix ] 회원가입 시, 프로필이 없다면 MyPage 및 MenuBar에서 기본이미지 띄우기
NYeonK Sep 18, 2022
7068e63
[ feat ] errorMessage 문구 추가
NYeonK Sep 20, 2022
c358b9b
[ feat ] 닉네임 입력 시, 공백 입력 막기
NYeonK Sep 20, 2022
0627ccb
[ feat ] 닉네임 유효성검증 정규표현식
NYeonK Sep 20, 2022
710bc71
[ feat ] 닉네임 입력 시, 특수문자 확인
NYeonK Sep 20, 2022
6cd5392
[ feat ] 특수 문자 입력 시, 에러메세지 띄우기
NYeonK Sep 20, 2022
02e85e8
[ feat ] 닉네임 수정 시, 공백 막기
NYeonK Sep 20, 2022
a4209ac
[ feat ] 닉네임 수정 시, 8글자 초과 막기
NYeonK Sep 20, 2022
2b5984e
[ feat ] 닉네임 수정 시, 특수문자 막기
NYeonK Sep 20, 2022
8f974a5
[ etc ] 주석 제거
NYeonK Sep 20, 2022
a182a26
[ refactor ] 코드리뷰 반영
NYeonK Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/@components/MyPage/NicknameModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ export default function NicknameModal(props: ModifyNicknameProps) {
}
};

const checkSpaceBar = (e: React.KeyboardEvent<HTMLInputElement>) => {
if (e.key === " ") {
e.preventDefault();
return false;
}
};

Comment on lines +38 to +44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 입력할 때 말고 valid 확인할 때 확인하지는 못하는 건가요??!

return (
<Modal closeHandler={closeHandler}>
<St.Container>
Expand All @@ -41,7 +48,13 @@ export default function NicknameModal(props: ModifyNicknameProps) {
</St.Wrapper>
<St.Wrapper>
<St.Label>새로운 닉네임</St.Label>
<St.NewNickname aria-label="새로운 닉네임 입력칸" type="text" id="newNickname" onChange={onChangeNickname} />
<St.NewNickname
aria-label="새로운 닉네임 입력칸"
type="text"
id="newNickname"
onChange={onChangeNickname}
onKeyDown={(e) => checkSpaceBar(e)}
/>
{errorMessage !== "" && <St.ErrorMessage>{errorMessage}</St.ErrorMessage>}
</St.Wrapper>
<St.ButtonWrapper>
Expand Down