Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using a certificate instead of a shared secret #170

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Add support for using a certificate instead of a shared secret #170

merged 1 commit into from
Sep 9, 2022

Conversation

uncaught
Copy link
Contributor

@uncaught uncaught commented Sep 9, 2022

Implements #115

@hajekj hajekj merged commit 1574a21 into TheNetworg:master Sep 9, 2022
weaverryan added a commit to knpuniversity/oauth2-client-bundle that referenced this pull request Oct 10, 2022
This PR was squashed before being merged into the master branch.

Discussion
----------

Add certificate support for Azure provider

Adds certificate support to the **Azure provider**:

- Makes configuration option `client_secret` optional
- Adds configuration options `client_certificate_private_key` and `client_certificate_thumbprint`

See TheNetworg/oauth2-azure#170 (merged) for the respective PR on the provider.

That PR is not released, yet, but there are no compatibility issues with this PR here. They can be installed independently without drawbacks.

Only to actually use certificates you had to have both PRs merged/released/installed.

Commits
-------

c7b5d12 Add certificate support for Azure provider
@quentinRogeret34
Copy link

Hello @hajekj ,
I am really interested in this feature developed on the ticket: knpuniversity/oauth2-client-bundle#379
However it depends on this feature. Do you know when the feature will be released?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants