Add certificate support for Azure provider

[uncaught]

Adds certificate support to the Azure provider:

• Makes configuration option client_secret optional
• Adds configuration options client_certificate_private_key and client_certificate_thumbprint

See TheNetworg/oauth2-azure#170 (merged) for the respective PR on the provider.

That PR is not released, yet, but there are no compatibility issues with this PR here. They can be installed independently without drawbacks.

Only to actually use certificates you had to have both PRs merged/released/installed.

[eerison]

for custom parameters I would suggest implement some client_extra_params, because every provider could have some custom implementation.

[eerison]

Or maybe some option to pass a client configured!

[uncaught]

Why is this different from all the other provider specific parameters like apple.key_file_id etc.?

[eerison]

IMO we we are just growing and growing this config!

for example

provider A, B, C, D ...: need the config

• X1
• X2
• X3

provider W: need the config

• X4
• X5
• X6

provider Y: need the config

• X7
• X8
• X9

most of the providers needs only the configs X1,2,3 But because few providers I need to add more and more config,
I don't see it as a good approach!

[uncaught]

Yes, but what exactly is the problem with that? The list of all the configs are only globally visible in the README.md, which simply lists all the providers with all their configs.

If you don't want to list all providers there anymore, then you could move the documentation to provider specific markdown files.

But the actual config parameters in the code were added in the provider specific configurator class. I don't see where this approach could be called growing out of hand.

The base configuration already only contains 4-5 options and leaves the rest to the provider specific configuration. If you want to change that, maybe by moving these 4-5 options to each provider individually and have no base config anymore, then that would be fine with me, but that would be a different PR then, setting a new standard for implementing providers.

[weaverryan]

This looks good to me - except two little code styling things to run:

A) php-cs-fixer fix --verbose --diff (once you have php-cs-fixer installed - you could even temporarily composer require it locally into this repo then just not commit the composer changes)

B) bin/update_readme - to regenerate part of the README

Cheers!

[weaverryan]

Thanks @uncaught!

[uncaught]

All green :) Is there something else missing?

[weaverryan]

Thanks for the poke - this DID get merged in with a rebase... and for some reason my system didn't close the PR. It's all good and in!

[quentinRogeret34]

Hello @weaverryan , I am really interested in this feature.
Do you know when you are going to release?

Thanks 🙏

[uncaught]

Hello @weaverryan , I am really interested in this feature. Do you know when you are going to release?

Thanks 🙏

Bare in mind, that TheNetworg/oauth2-azure#170 hasn't been released, yet, either. So you could install that repository from master or had to wait for their release, too.