Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race in compilation? #461

Closed
jonasdn opened this issue Aug 17, 2021 · 5 comments
Closed

Race in compilation? #461

jonasdn opened this issue Aug 17, 2021 · 5 comments
Assignees

Comments

@jonasdn
Copy link

jonasdn commented Aug 17, 2021

Hi!

In the repository crazyflie-testing we build and test Crazyswarm each night, occasionally it will fail.

It did today, and ten days ago:

When it fails it fails in compilation with:

[ 94%] Generating C++ code from crazyswarm/NotifySetpointsStop.srv
[ 94%] Generating C++ code from crazyswarm/SetGroupMask.srv
/__w/crazyflie-testing/crazyflie-testing/crazyswarm/ros_ws/src/crazyswarm/src/crazyswarm_server.cpp:8:10: fatal error: crazyswarm/UpdateParams.h: No such file or directory
    8 | #include "crazyswarm/UpdateParams.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Although nothing seem to have changed in the source between runs. Is there some kind of race between generation and compilation perhaps?

@whoenig whoenig self-assigned this Aug 17, 2021
@whoenig
Copy link
Contributor

whoenig commented Aug 17, 2021

There is certainly a dependency issue that we fixed here: https://github.com/USC-ACTLab/crazyswarm/blob/master/build.sh#L27-L29. Since you are just calling build.sh, I guess we would actually need to try to fix the actual dependency in the catkin build system.

@jonasdn
Copy link
Author

jonasdn commented Aug 17, 2021

Ok! What is the alternative to "just calling build.sh" ?

@whoenig
Copy link
Contributor

whoenig commented Aug 17, 2021

That's the right approach - sorry for the confusion. I'll keep this open as a bug here and try to fix the dependency properly!

whoenig added a commit that referenced this issue Aug 17, 2021
This dependency is required if the srv/msg descriptions are in the same
package, see https://answers.ros.org/question/53265/catkin-messages-and-node-in-same-package/

Fixes issue #461.
@whoenig
Copy link
Contributor

whoenig commented Aug 17, 2021

I hope that this is fixed in master now. @jonasdn, please reopen this issue if you see this again as we didn't see it in our CI and I was unable to reproduce the problem on a parallel build with 24 cores.

@whoenig whoenig closed this as completed Aug 17, 2021
@jonasdn
Copy link
Author

jonasdn commented Aug 17, 2021

Thanks Wolfgang!

boomer319 referenced this issue in boomer319/verrueckterschwarm2 Nov 25, 2023
This dependency is required if the srv/msg descriptions are in the same
package, see https://answers.ros.org/question/53265/catkin-messages-and-node-in-same-package/

Fixes issue IMRCLab#461.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants