Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency for nodes to messages #462

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Add dependency for nodes to messages #462

merged 1 commit into from
Aug 17, 2021

Conversation

whoenig
Copy link
Contributor

@whoenig whoenig commented Aug 17, 2021

This dependency is required if the srv/msg descriptions are in the same
package, see https://answers.ros.org/question/53265/catkin-messages-and-node-in-same-package/

Fixes issue #461.

This dependency is required if the srv/msg descriptions are in the same
package, see https://answers.ros.org/question/53265/catkin-messages-and-node-in-same-package/

Fixes issue #461.
@whoenig whoenig requested a review from jpreiss August 17, 2021 17:51
@jpreiss
Copy link
Collaborator

jpreiss commented Aug 17, 2021

Honestly I'm not familiar enough with Catkin/CMake to properly review this, but it looks like it correctly implements the not-accepted answer in the linked ROS Q/A.

It's interesting that this flaky build never occurred for us in CI...

@whoenig whoenig merged commit a68bd9f into master Aug 17, 2021
@whoenig whoenig deleted the issue461 branch August 17, 2021 18:46
boomer319 referenced this pull request in boomer319/verrueckterschwarm2 Nov 25, 2023
Add dependency for nodes to messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants