Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No access to the NC_SHARE flag. #55

Closed
ernestum opened this issue Mar 9, 2018 · 3 comments
Closed

No access to the NC_SHARE flag. #55

ernestum opened this issue Mar 9, 2018 · 3 comments
Assignees
Milestone

Comments

@ernestum
Copy link

ernestum commented Mar 9, 2018

The NC_SHARE flag can not be accessed from this c++ library. Is there any particular reason for this? You can read more about the NC_SHARE flage here.

@WardF
Copy link
Member

WardF commented Mar 14, 2018

This is odd, it should be available. What happens when you try to open a file, and specify NC_SHARE?

@ernestum
Copy link
Author

It is just plain not possible. If you have a look at the open method of ncFile where the nc_open/nc_create of the underlying c library is called, you see, that there is no way for me to control flags directly. I can only indirectly make it use one of NC_WRITE, NC_NOWRITE, NC_NETCDF4 | NC_NOCLOBBER, NC_NETCDF4 | NC_CLOBBER based on the file mode that I provide. This is by the way the only place in the library, that nc_create/nc_open are called. That means the is not other detour I could take to get the NC_SHARE flag in.

@WardF WardF self-assigned this Jun 11, 2018
@WardF WardF added this to the 4.3.1 milestone Jun 11, 2018
@WardF
Copy link
Member

WardF commented Jun 19, 2018

Updated ncFile.cpp to add a constructor that will take any/all flags from netcdf.h. Got a test in the pipeline now, will close this out once it's merged.

@WardF WardF closed this as completed in #56 Jun 19, 2018
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jun 3, 2023
\Brief Release notes file for the netcdf-cxx4 package.

This file contains a high-level description of this package's
evolution. Releases are in reverse chronological order (most recent
first).

Note that this file was created and maintained starting with the `netcdf-cxx4 4.3.0 release`.

## netCDF-CXX4 4.3.2 TBD

## netCDF-CXX4 v4.3.1 September 11, 2019

### Requirements

* netCDF-C 4.6.0 or greater

### Changes

* [Enhancement] Added cmake support to distribution files created by `make dist`.

* [Bug Fix] Added `ncFile::create()`, also added a new `open` function
  and constructor to allow for more flexibility when opening a file.
  See [GitHub #55](Unidata/netcdf-cxx4#55)
  for more information.

* [Enhancement] Addressed an issue reported with `Intel Compilers
  17.0.0`. See [GitHub
  #41](Unidata/netcdf-cxx4#41) for more
  information.

* [Enhancement] Updated how `configure` determines information about
  the existing netCDF-C install.  See [GitHub pull request
  #39](Unidata/netcdf-cxx4#39) for more
  information.

* Corrected an issue where cmake-based builds weren't generating
  `ncxx4-config`.  See [GitHub pull request
  #37](Unidata/netcdf-cxx4#37) for more
  information.


## netcdf-cxx4 v4.3.0 released May 13, 2016

* Fixed an issue where the tests were failing silently, and the
  underlying `NcType` class could not properly determine the type name
  or type size reliably. See [GitHub issue
  #30](Unidata/netcdf-cxx4#30) for more
  information.

* Changed `NCXX_ENABLE_DOXYGEN` option to an easier-to-remember `ENABLE_DOXYGEN`.

* Added `--enable-doxygen`, `-DNCXX_ENABLE_DOXYGEN=ON` options to
  allow generation of netCDF-CXX4 documentation via doxygen using
  either `configure` or `cmake`, respectively.

* Added `netcdf-cxx4` to the [Coverity Scan
  Dashboard](https://scan.coverity.com/projects/unidata-netcdf-cxx4?tab=overview).

* Added `open` and `close` methods for NcFile.  See [Github Pull
  Request #18](Unidata/netcdf-cxx4#18) for
  more information.

* Added `netcdf-cxx4` to travis-ci.org.  See
  [https://travis-ci.org/Unidata/netcdf-cxx4](https://travis-ci.org/Unidata/netcdf-cxx4)
  for more details.

* Added `NcCompoundType` methods `getMemberName` and `getMemberIndex`.
  See [Pull Request
  #19](Unidata/netcdf-cxx4#19) for more
  details.

* Added  `cmake` support  to  `netcdf-cxx4`, which  will  allow us  to
  create a  `CDash` continuous integration dashboard  similar to those
  created for the `netcdf-c` and `netcdf-fortran` projects.

* Added a `travis-ci` configuration file, `.travis.yml`.

* Created `RELEASE_NOTES.md`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants