Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: generate ncxx4-config in cmake builds #37

Merged
merged 2 commits into from
Jul 5, 2016
Merged

FIX: generate ncxx4-config in cmake builds #37

merged 2 commits into from
Jul 5, 2016

Conversation

kmuehlbauer
Copy link
Contributor

This adds generation of ncxx4-config to the cmake build. Directly adapted from the configure approach. Tested locally.

Solves #36. In urgent need for conda-forge/netcdf-cxx4-feedstock#9.

@kmuehlbauer
Copy link
Contributor Author

Seems like I haven't correctly applied some CMAKE variables. Fixed.

This was referenced Jun 7, 2016
Merged
Merged
@kmuehlbauer
Copy link
Contributor Author

There is more missing to the final ncxx4-config file. I also get an [: too many arguments error, but can't track it down.

@WardF
Copy link
Member

WardF commented Jun 7, 2016

Ok, I have a few other things on my plate but I'll try to nail this down today or possibly tomorrow. Thank you very much for contributing this, however, it is very much appreciated!

@WardF WardF added this to the 4.3.0 milestone Jun 7, 2016
@WardF WardF self-assigned this Jun 7, 2016
@kmuehlbauer
Copy link
Contributor Author

Thanks for taking the time. Still, there is something not working correctly with this PR. I'll also have another look tomorrow (european time), If you want me something to do, just ping me.

@kmuehlbauer
Copy link
Contributor Author

@WardF Any news on that?

1 similar comment
@kmuehlbauer
Copy link
Contributor Author

@WardF Any news on that?

@WardF
Copy link
Member

WardF commented Jun 30, 2016

Hi, none yet, we had some fires to put out but now that 4.4.1 is out I'll see if I can knock this out in short order. Thanks for your patience!

@WardF
Copy link
Member

WardF commented Jul 5, 2016

I've identified and corrected the error; when the travis-ci checks finish I'll merge into master. Thanks again!

WardF added a commit that referenced this pull request Jul 5, 2016
@WardF
Added reference to #37 to release notes.
a450adc
@WardF WardF merged commit 1114789 into Unidata:master Jul 5, 2016
@WardF
Copy link
Member

WardF commented Jul 5, 2016

Merged, thanks again! Incidentally, I used the command line utility shellcheck to quickly figure out where the issue was in the script template, just FYI :).

@kmuehlbauer
Copy link
Contributor Author

Merged, thanks again! Incidentally, I used the command line utility shellcheck to quickly figure out where the issue was in the script template, just FYI :).

Thanks for the hint, I'll keep that in mind for the future.

As we are relying on releases, any plans for a 4.3.1 release? Otherwise we would need to build from the latest commit.

@WardF
Copy link
Member

WardF commented Jul 5, 2016

There haven't been a lot of changes since the previous release, so there aren't any immediate plans for a new release. I can schedule one, but it will be in the near future; in the short-term (next few weeks) I have other priorities I have to attend to.

@kmuehlbauer
Copy link
Contributor Author

That's fine. Shall #36 be closed then?

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 3, 2023
(devel/netcdf-cxx) Updated 4.2 to 4.3.1
efb12c3 
\Brief Release notes file for the netcdf-cxx4 package.

This file contains a high-level description of this package's
evolution. Releases are in reverse chronological order (most recent
first).

Note that this file was created and maintained starting with the `netcdf-cxx4 4.3.0 release`.

## netCDF-CXX4 4.3.2 TBD

## netCDF-CXX4 v4.3.1 September 11, 2019

### Requirements

* netCDF-C 4.6.0 or greater

### Changes

* [Enhancement] Added cmake support to distribution files created by `make dist`.

* [Bug Fix] Added `ncFile::create()`, also added a new `open` function
  and constructor to allow for more flexibility when opening a file.
  See [GitHub #55](Unidata/netcdf-cxx4#55)
  for more information.

* [Enhancement] Addressed an issue reported with `Intel Compilers
  17.0.0`. See [GitHub
  #41](Unidata/netcdf-cxx4#41) for more
  information.

* [Enhancement] Updated how `configure` determines information about
  the existing netCDF-C install.  See [GitHub pull request
  #39](Unidata/netcdf-cxx4#39) for more
  information.

* Corrected an issue where cmake-based builds weren't generating
  `ncxx4-config`.  See [GitHub pull request
  #37](Unidata/netcdf-cxx4#37) for more
  information.


## netcdf-cxx4 v4.3.0 released May 13, 2016

* Fixed an issue where the tests were failing silently, and the
  underlying `NcType` class could not properly determine the type name
  or type size reliably. See [GitHub issue
  #30](Unidata/netcdf-cxx4#30) for more
  information.

* Changed `NCXX_ENABLE_DOXYGEN` option to an easier-to-remember `ENABLE_DOXYGEN`.

* Added `--enable-doxygen`, `-DNCXX_ENABLE_DOXYGEN=ON` options to
  allow generation of netCDF-CXX4 documentation via doxygen using
  either `configure` or `cmake`, respectively.

* Added `netcdf-cxx4` to the [Coverity Scan
  Dashboard](https://scan.coverity.com/projects/unidata-netcdf-cxx4?tab=overview).

* Added `open` and `close` methods for NcFile.  See [Github Pull
  Request #18](Unidata/netcdf-cxx4#18) for
  more information.

* Added `netcdf-cxx4` to travis-ci.org.  See
  [https://travis-ci.org/Unidata/netcdf-cxx4](https://travis-ci.org/Unidata/netcdf-cxx4)
  for more details.

* Added `NcCompoundType` methods `getMemberName` and `getMemberIndex`.
  See [Pull Request
  #19](Unidata/netcdf-cxx4#19) for more
  details.

* Added  `cmake` support  to  `netcdf-cxx4`, which  will  allow us  to
  create a  `CDash` continuous integration dashboard  similar to those
  created for the `netcdf-c` and `netcdf-fortran` projects.

* Added a `travis-ci` configuration file, `.travis.yml`.

* Created `RELEASE_NOTES.md`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WardF WardF

Labels
status/under consideration status/under review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kmuehlbauer @WardF