Skip to content

Commit

Permalink
update .gitignore (#586)
Browse files Browse the repository at this point in the history
* fix .gitignore: /vunit/test is now /tests
* tests/acceptance/test_artificial: use 'artificial_out' instead of 'artificial out', for gitignore pick it
* .gitignore: add generated vunit/vhdl/check/test/tb_check_*.vhd
  • Loading branch information
umarcor authored and 1138-4EB committed Nov 16, 2019
1 parent d1dfdd9 commit 017e0c5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
*.o
*.so
*.egg-info
.vscode
.devcontainer
.tox
.vscode
docs/_build
docs/examples.rst
docs/release_notes.rst
.tox
vunit/test/acceptance/*_out
vunit/test/unit/test_report_output.txt
env/
tests/acceptance/*_out
tests/unit/test_report_output.txt
venv/
vunit/vhdl/check/test/tb_check_equal.vhd
vunit/vhdl/check/test/tb_check_match.vhd
2 changes: 1 addition & 1 deletion tests/acceptance/test_artificial.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class TestVunitArtificial(unittest.TestCase):

def setUp(self):
# Spaces in path intentional to verify that it is supported
self.output_path = join(dirname(__file__), "artificial out")
self.output_path = join(dirname(__file__), "artificial_out")

This comment has been minimized.

Copy link
@felixn

felixn Nov 17, 2019

Contributor

The comment in the line above makes me think that it was a concious decision to use a space instead of an underscore.
Why not simply vunit/test/acceptance/artificial\ out in .gitignore?

This comment has been minimized.

Copy link
@eine

eine Nov 17, 2019

Collaborator

Good catch! b92057c

self.report_file = join(self.output_path, "xunit.xml")
self.artificial_run_vhdl = join(
dirname(__file__), "artificial", "vhdl", "run.py"
Expand Down

0 comments on commit 017e0c5

Please sign in to comment.