Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: merge data_types/src/types/* into data_types/src/types.vhd #543

Merged
merged 4 commits into from
Sep 20, 2019

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Sep 17, 2019

Currently, there are two files with 5 lines each. When byte_vector is added in #507, there will be three. Apart from being short, the content is tightly related. As proposed in #507, a single types_pkg package is defined, and all the types are put there.

Moreover, as commented in #507, the definition of byte_t is moved from verification_components/**/memory_pkg.vhd to this data_types/**/types.vhd.


Also, in #507, type storage_mode_t is (internal, extfnc, extacc); is defined in string_ptr_pkg.vhd. This type is to be later used by integer_vector_ptr_pkg.vhd (#476) and memory_pkg.vhd (#470). Therefore, it makes sense to make byte_t and storage_mode_t available in a similar fashion.

@umarcor umarcor changed the title style: merge vunit/vhdl/data_types/src/types/* into vunit/vhdl/data_types/src/types.vhd style: merge data_types/src/types/* into data_types/src/types.vhd Sep 17, 2019
@umarcor
Copy link
Member Author

umarcor commented Sep 19, 2019

@LarsAsplund, I updated this issue and I believe it is ready to merge. However, there is something strange going on with Travis.

This is very strange because this PR is not rebased on top of master yet. Therefore, even if the latest commit in master is broken, this PR should succeed (as it does on my fork).

EDIT

I replied to myself.. the commit is automatically merged with master

@LarsAsplund LarsAsplund merged commit b1b0287 into VUnit:master Sep 20, 2019
@umarcor umarcor deleted the feat-merge-types branch September 20, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants