Refactoring for subset compile #549
Conversation
…_order These two functions used a lot of similar code. The code is now split into functions. These will also be used in future for the functionality to compile only the required subset of files.
SourceFile, VerilogSourceFile and VHDLSourceFile now reside in own module source_file
|
Hi @dstadelm! It seems that this PR is a subset of #550. Could you, please, make it explicit? I'd suggest adding Regarding this PR, would you mind either elaborating your first comment or further splitting these commits? The main motivation seems to be to reduce duplicate code. However, the proposed implementation is 10% larger. It might be legitimate, but it is hard to see it in the current state. For example, it seems that 5 lines of code are split to a new |
| """ | ||
| Get a list of all files in compile order | ||
| incremental -- Only return files that need recompile if True | ||
| :param incremental: -- Only return files that need recompile if True |
There was a problem hiding this comment.
Is -- a typo?
Also, please, add descriptions for dependency_graph and files too.
|
Shure thing. I'll create a new pull request. Regards |
It is up to you, of couse; but it is not required to close and open new PRs for these changes. You can just push commits or force-push this branch. The advantage of doing so is that it is easier for us to see previous comments/discussions. It is useful to see different versions of a contribution, because it helps understand which decisions were made. |
|
Ok, I didn't know about that, especially the force push. My new pull request does not comply with one pylint instance check. I don't know why, because it is complaining about code I didn't touch.... |
This refactores the functions get_files_in_compile_order and get_dependencies_in_compile_order in the first commit. This was done as quite a lot of code is duplicate code.
In the second commit the SourceFile, VHDLSourceFile and VerilogSourceFile classes are refactored to a seperate module. As pycodestyle complained that the file project.py is too long.