Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sim_if and test submodules #582

Merged
merged 5 commits into from
Nov 14, 2019
Merged

Create sim_if and test submodules #582

merged 5 commits into from
Nov 14, 2019

Conversation

eine
Copy link
Collaborator

@eine eine commented Nov 3, 2019

Following the same approach as with ui.py, in this PR:

  • A vunit.sim_if submodule is created.
  • Submodule test is renamed to tests.
  • A new submodule names test is created, and all the vunit/test_*.py sources are moved there.
  • vunit.ui.vunit is merged into vunit/ui/__init__.py and unused imports are removed.

@kraigher
Copy link
Collaborator

I am basically ok with this as it makes the structure better. Regarding test vs tests I think tests should really be outside the vunit folder. Moving it outside also makes it less confusing.

@eine
Copy link
Collaborator Author

eine commented Nov 13, 2019

Regarding test vs tests I think tests should really be outside the vunit folder. Moving it outside also makes it less confusing.

Good idea! It is done now. BTW, builtins imported simulator_check from vunit.test.common (which is now tests.common). However, I think that vunit should not depend on tests. Hence, I moved three helper functions from tests.common to vunit.sim_if.common.

@eine eine merged commit ba1ef07 into VUnit:master Nov 14, 2019
@eine eine deleted the sim-if branch November 14, 2019 04:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants