Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/vhdl: use pathlib instead of join and dirname #612

Merged
merged 1 commit into from
Jan 23, 2020
Merged

examples/vhdl: use pathlib instead of join and dirname #612

merged 1 commit into from
Jan 23, 2020

Conversation

eine
Copy link
Collaborator

@eine eine commented Jan 15, 2020

Since Python 2 is deprecated, in this PR the run.py files in examples/vhdl/** are modified to use Path from pathlib, instead of join and dirname from os.path.

At the same time in a couple of places popen from os was used. Those are replaced with check_call from subprocess.

@eine eine merged commit beb161f into VUnit:master Jan 23, 2020
@eine eine deleted the use-pathlib branch January 23, 2020 19:23
@felixn felixn mentioned this pull request Feb 13, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eine