Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check_relation using default checker #971

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Fix check_relation using default checker #971

merged 1 commit into from
Nov 19, 2023

Conversation

kraigher
Copy link
Collaborator

@kraigher kraigher commented Nov 4, 2023

I am working on adding unused code warnings to VHDL LS and noticed that the checker argument to this procedure was unused.

@kraigher
Copy link
Collaborator Author

kraigher commented Nov 4, 2023 •
edited
Loading

Also note that the run_stability_check has an unused active_clock_edge parameter which might be a bug: https://github.com/VUnit/vunit/blob/master/vunit/vhdl/check/src/check.vhd#L863C14-L863C31

@LarsAsplund LarsAsplund merged commit 87d5b4a into master Nov 19, 2023
22 of 29 checks passed
@eine eine deleted the fix-check-relation branch February 24, 2024 22:20
@eine eine added this to the v5.0.0 milestone Mar 11, 2024
@umarcor
Copy link
Member

umarcor commented Mar 11, 2024

See #997.

@umarcor umarcor mentioned this pull request Mar 13, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kraigher @umarcor @eine @LarsAsplund