Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feature to allow switching to rustls #11

Closed
wants to merge 1 commit into from

Conversation

tomtau
Copy link

@tomtau tomtau commented Mar 16, 2023

Description

allow switching to rustls in tokio-tungstenite: we find rustls to be more portable, so we prefer using that

Resolves # N/A #9

How Has This Been Tested?

using cargo run --example basic_client --features full, plus a custom partial Sign API implementation

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@heilhead
Copy link
Collaborator

Thanks! I've replaced it with #12 to also update our CI workflow to run cocogitto to verify commits, and update the commit message.

@heilhead heilhead closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants