Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: client rustls support #12

Merged
merged 3 commits into from
Mar 16, 2023
Merged

feat: client rustls support #12

merged 3 commits into from
Mar 16, 2023

Conversation

heilhead
Copy link
Collaborator

Description

Replaces #11.

Also adds cocogitto to the default CI workflow.

How Has This Been Tested?

Manually.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@heilhead heilhead mentioned this pull request Mar 16, 2023
Closed
3 tasks
@heilhead heilhead requested a review from farazdagi March 16, 2023 08:10
@farazdagi
Copy link
Contributor

Should we have all 3 commits of this PR squashed into feat: client rustls support, so that it adheres to conventional commits?

farazdagi
farazdagi approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge or squash and force push within a single conventional commit.

@heilhead
Copy link
Collaborator Author

@farazdagi Yeah, squashing was the plan.

@heilhead heilhead merged commit b44beee into main Mar 16, 2023
@heilhead heilhead deleted the feat/rustls branch March 16, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farazdagi farazdagi farazdagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heilhead @farazdagi