Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Running tests with USE_LDAP enabled outside of Yale breaks things #1411

Closed
3 tasks
orenyk opened this issue Jan 7, 2016 · 0 comments · Fixed by #1618
Closed
3 tasks

Running tests with USE_LDAP enabled outside of Yale breaks things #1411

orenyk opened this issue Jan 7, 2016 · 0 comments · Fixed by #1618

Comments

@orenyk
Copy link
Contributor

orenyk commented Jan 7, 2016

While waiting for my car to get serviced and trying to get work done, I encountered a bunch of failed tests due to LDAP lookup timeouts as I had USE_LDAP set from a different issue (#1375). I'll verify that everything passes when LDAP is disabled, but we should probably enforce ENV['USE_LDAP'] = nil for the test environment. If we really wanted to do things right, we'd also go through and either remove all tests that are directly related to LDAP and/or stub LDAP queries somehow.

Here are the tests that failed before I killed Rspec (was taking forever):

  • spec/controllers/users_controller_spec.rb:59
  • spec/controllers/import_users_controller.rb (a bunch)

Let's do it right:

  • ensure USE_LDAP defaults to nil in test
  • properly stub LDAP queries and run them in isolated blocks with ENV modified
  • go through all LDAP-related specs and make sure they're actually worth testing
@orenyk orenyk added this to the 6.1.0 milestone Jan 7, 2016
@orenyk orenyk modified the milestones: 6.1.0, 6.2.0 Jun 1, 2016
@esoterik esoterik modified the milestones: 6.3.0, 6.2.0 Jul 5, 2016
@esoterik esoterik modified the milestones: 6.4.0, 6.3.0 Aug 3, 2016
@esoterik esoterik self-assigned this Aug 4, 2016
@esoterik esoterik modified the milestones: 6.4.0, 6.2.0 Sep 9, 2016
esoterik pushed a commit that referenced this issue Oct 28, 2016
esoterik pushed a commit that referenced this issue Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants