Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Ensure we're using AppConfig.check everywhere #1584

Closed
orenyk opened this issue Jun 16, 2016 · 0 comments
Closed

Ensure we're using AppConfig.check everywhere #1584

orenyk opened this issue Jun 16, 2016 · 0 comments
Assignees
@esoterik
Labels
diff: 1 pri: 2 type: refactor
Milestone
Summer 2016 Lefto...

Comments

@orenyk
Copy link
Contributor

orenyk commented Jun 16, 2016

Bad = AppConfig.first.foo
Good = AppConfig.check :foo

Let's make sure we're not doing any of the former. Note that this only works for boolean parameters / settings; we're still going to manually call AppConfig.first to access other settings (e.g. admin e-mail, etc).
@orenyk orenyk added this to the 6.2.0 milestone Jun 16, 2016
esoterik pushed a commit that referenced this issue Jun 21, 2016
Ensure that AppConfig#check is used
d7dfab0 
Resolves #1584
@esoterik esoterik modified the milestone: 6.2.0 Sep 9, 2016
esoterik pushed a commit that referenced this issue Nov 29, 2016
add #1633 #1584 #1411
c38c801
yongjie-lin pushed a commit that referenced this issue Jan 29, 2017
Add tests for conflicting reservations when editing blackouts
e9b0c06 
Fix #1645

Create service object for updating blackouts

Ensure that AppConfig#check is used

Resolves #1584

6.2.0 changelog

Refactor Blackouts controller and BlackoutsUpdater

Fix style issues

Fix style bug

Revert "Merge branch 'master' of https://github.com/YaleSTC/reservations into
1645_blackout_conflict_checking"

Update BlackoutUpdater tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@esoterik esoterik

Labels
diff: 1 pri: 2 type: refactor
Projects
None yet
Milestone
Summer 2016 Leftovers
Development

No branches or pull requests
2 participants
@orenyk @esoterik