Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RTN20C: Handle os connectivity event while CONNECTING #1626

Closed
deanna-lad opened this issue Apr 6, 2023 · 3 comments · Fixed by #1703
Closed

Implement RTN20C: Handle os connectivity event while CONNECTING #1626

deanna-lad opened this issue Apr 6, 2023 · 3 comments · Fixed by #1703
Assignees

Comments

@deanna-lad
Copy link

See ably/specification#135 and RTN20c

When CONNECTING, if the operating system indicates that the underlying internet connection is now available, the client should restart the pending connection attempt

As part of this work, we should also ensure that RTN20a and RTN20c are implemented correctly. Also, "Connection: Handle OS connectivity events" should be added to the features.yml file.

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 6, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3507

@maratal
Copy link
Collaborator

maratal commented May 2, 2023

https://sdk.ably.com/builds/ably/specification/main/features/#RTN20a

When CONNECTED, CONNECTING or DISCONNECTING, if the operating system indicates that the underlying internet connection is no longer available...

Is DISCONNECTING even a thing?

enum ConnectionState: // RTN4
  INITIALIZED
  CONNECTING
  CONNECTED
  DISCONNECTED
  SUSPENDED
  CLOSING
  CLOSED
  FAILED

@SimonWoolf @owenpearson

@owenpearson
Copy link
Member

@maratal yeah DISCONNECTING is not a thing - that should say DISCONNECTED. See ably/specification#146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants