Fix/1626 handle reachability events #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maratal
force-pushed
the
fix/1626-handle-reachability-events
branch
from
55f157d
to
40303c0
Compare
maratal
force-pushed
the
fix/1626-handle-reachability-events
branch
from
83441eb
to
29fb344
Compare
There was a problem hiding this comment.
I've put a few comments on the code. Also, I found the commits and their messages a bit confusing — 40303c0’s message doesn't make it clear that it's implementing a new feature, it sounds like a bug fix or a refactor or something. And wouldn't it then make sense to put the test in the same commit that implements the feature?
maratal
force-pushed
the
fix/1626-handle-reachability-events
branch
from
29fb344
to
08ba4c8
Compare
…tart of the connection that have been just started. There is no certain way to detect whether reachability callback was called because you've just set it up, or because it really has detected reachability of the host. So we rely on a short timeout here - if the callback was called shortly after the setting up reachability, then reconnection shouldn't be done. Whereas if it was called after the certain delay (a threshold) - than it means you are in the middle of the dead-end connection attemt and it should be restarted. See #1713 for more details.
maratal
force-pushed
the
fix/1626-handle-reachability-events
branch
from
08ba4c8
to
c40bdad
Compare
lawrence-forooghian
approved these changes
May 16, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1691
Closes #1626
See commit comments for more details.