Addressing workaround for RTN20c #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CONNECTING, reachability now activated after token request is complited. During token request user will receive the request error in case of unreachable network." This reverts commit 3eac846.
maratal
requested review from
lawrence-forooghian
and removed request for
lawrence-forooghian,
sacOO7,
ttypic and
umair-ably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1713
This PR reverts the work from this PR and the fix for it from this PR.
The idea is to ignore the first report of reachability with status "reachable" since it's not needed¹ - if the host is reachable, then the connection will proceed as expected. If the first call reports the host as "unreachable", then the realtime will fall into disconnected/suspended. And when the system will again report the host as reachable, then this call will not be ignored since the previous one was "unreachable" (in oppose to the first call where the previous one is "unknown").
¹ - the system always calls reachability callback immediately after the callback is set by the user (to initialize the user's state).