Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RTN20): DISCONNECTING -> DISCONNECTED #146

Merged
merged 1 commit into from
May 2, 2023

Conversation

owenpearson
Copy link
Member

This appears to have been a typo - DISCONNECTING is not a valid connection state

@owenpearson owenpearson requested review from maratal and a team May 2, 2023 14:50
@github-actions github-actions bot temporarily deployed to staging/pull/146 May 2, 2023 14:51 Inactive
@SimonWoolf
Copy link
Member

looks like the DISCONNECTED case is handled by RTN20b below? (and "When DISCONNECTED ... the client library should immediately transition the state to DISCONNECTED" wouldn't make sense)

textile/features.textile Outdated Show resolved Hide resolved
@owenpearson
Copy link
Member Author

Ah, my bad, thanks both. I've changed it to just remove the mention of DISCONNECTING entirely.

@owenpearson owenpearson requested a review from maratal May 2, 2023 15:02
@owenpearson owenpearson merged commit 56e6faa into main May 2, 2023
@owenpearson owenpearson deleted the rtn20-disconnecting-fix branch May 2, 2023 15:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants