Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated tags can visually overlap #228

Closed
saroff opened this issue Apr 3, 2018 · 3 comments
Closed

Generated tags can visually overlap #228

saroff opened this issue Apr 3, 2018 · 3 comments
Labels

Comments

@saroff
Copy link

saroff commented Apr 3, 2018

See attached screenshot, tag containing 3 letters can't be selected, because another tag will be selected after first 2 letters are typed.

image

@breandan
Copy link
Collaborator

breandan commented Apr 6, 2018

@saroff Thank you for the detailed bug reports! This is a problem I have also noticed if the tags are bunched too closely. However, this is not caused by ambiguous tags, but overlapping tags. The tag on line 1095 you highlighted is not really IH (although it looks like it) but HG I? and JH (there are three tags on line 1095). There are two problems here: first, tags can visually overlap and second, typing a key in line mode does not remove unrelated tags. The first issue is a regression in Marker, which paints tags to the screen. And the second issue is caused by a problem in Finder, which removes old highlights. For these reasons, Line Mode is slightly unstable in the latest release.

breandan added a commit that referenced this issue Oct 8, 2018
@breandan
Copy link
Collaborator

breandan commented Oct 8, 2018

I think a quick solution here could be to draw a border around the tags to visually separate adjacent but overlapping tags.

@breandan breandan changed the title Bug: generated tags sometimes can be ambiguous. Generated tags can visually overlap Oct 13, 2018
@breandan breandan added the bug label Oct 13, 2018
@breandan
Copy link
Collaborator

breandan commented Apr 4, 2021

This should be fixed in 3.7.0. Feel free to give it a try and leave your feedback!

@breandan breandan closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants