Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect horizontal tag placement when parameter hints enabled #233

Closed
saroff opened this issue May 10, 2018 · 4 comments
Closed

Incorrect horizontal tag placement when parameter hints enabled #233

saroff opened this issue May 10, 2018 · 4 comments

Comments

@saroff
Copy link

saroff commented May 10, 2018

image

See screenshot. I can't find any stable repro steps for it though. It always happens for me only in 1 file. I tried creating some stub files with long enough lines, no luck.

@saroff saroff changed the title Bug: Tag's sometimes can be partially not visible. Bug: Tags can be invisible, if parameter hint feature is enabled. May 10, 2018
@saroff
Copy link
Author

saroff commented May 10, 2018

Found it!
The problem is parameter hint feature in IDEA, that changes length of line. See screenshot. So the problem is on the line with parameter hint, that is long enough. On screenshot you can see most line-end tags on long lines don't visible at all, and one of them is only partially visible.

image

@breandan
Copy link
Collaborator

Thank you for the careful bug report, this is really helpful. We calculate the tag's (x, y) position here. Our calculation will either need to take into account type and parameter hints, or use a higher level API. I think we must be using the Editor Coordinate System API incorrectly, or should be using a higher level of abstraction than the one we are currently using (in case anyone wants to investigate this).

@breandan breandan added the bug label May 22, 2018
@breandan breandan changed the title Bug: Tags can be invisible, if parameter hint feature is enabled. Incorrect horizontal tag placement when parameter hints enabled Apr 3, 2019
@chylex
Copy link
Collaborator

chylex commented Nov 25, 2020

Similar issue exists with text highlights, for ex. typing 1F here shows up as:
obrazek

I'm working on a refactor and fixing various issues as I go, so in this example I typed getter, () -> and the highlight travels across inlay hints (although it perhaps starts too soon, I'll see if I can improve that):
obrazek

I wasn't actually able to reproduce this with markers in recent versions, only highlights seem broken.

@breandan
Copy link
Collaborator

breandan commented Apr 4, 2021

Thanks to #353 has now been fixed in 3.7. Feel free to try it out and leave your feedback!

@breandan breandan closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants