fix xbox controller buttons #47
Conversation
|
cc @NoahBres |
|
I never tested the Xbox 360 controller because of the inability to refactor the id system using PID/VID. I just left the original implementation in. I have no idea whether it follows the standard w3 spec or not. Perhaps the browser implementation may have changed since you originally created it. The spec isn't very solid so that would not be so far-fetched. Would you like me to test it? I can get access to one by next week if so. But I'm assuming smartynenko has done so and this PR is based on their own testing. |
|
@smartynenko Can you include the OS, browser, and gamepad ID tuples that you've tested? A comment in the source would be great. @NoahBres More testing would help, but I'm fine being lazy and waiting for people to report broken mappings. |
|
@smartynenko Thanks. Sorry to be a pain, but I want to be precise. Is the |
|
np. are you referring to gamepad.id field? My controller reports identifies itself as |
|
Yes. In both browsers? I guess the VID/PID isn't exposed through the API. Also is |
|
correct, same |
|
Awesome. It'd be great if you could slip those strings into the comment. |
|
Perfect. Thanks! |
* fix xbox controller buttons * add controller and browser details * updated controller details Co-authored-by: Sergei Martynenko <sergei.martynenko@gm.com>
Current Xbox 360 button assignment appear to be incorrect and do not match controller return values. Could you update mapping to match standard gamepad layot ?