adobe-fonts.github.io color issues

[532910]

https://adobe-fonts.github.io/source-sans-pro/, https://adobe-fonts.github.io/source-serif-pro/ and https://adobe-fonts.github.io/source-code-pro/ doesn't redefine colors, so all of them look fine in the dark browsers:

But when mouse is over, all are completely unreadable:

You should define both foreground and background colors together, implicitly, or not define them at all. Really you shouldn't reproduce it (just define both fg and bg and don't rely on common defaults), but if you want, it is firefox with browser.display.use_system_colors = true and env GTK_THEME=Adwaita:dark

[pauldhunt]

can you update the source and submit a pull request? or provide the code necessary for me to plug into it? thanks.

[532910]

1. I don't see web page source in this repo.

2. The issue is here:

div:hover
{
    background-color: #EEE;
}

[frankrolf]

I am currently fixing this problem for the Source Serif specimen page, but I could not get a dark background to appear, even when setting dark mode globally.
The solution would be setting the colors explicitly, like this:

        @media (prefers-color-scheme: dark) {
            body {
                background-color: #222;
                color: #FFF;
            }
            div:hover
            {
                background-color: #333;
            }
        }
        @media (prefers-color-scheme: light) {
            body {
                background-color: #FFF;
                color: #000;
            }
            div:hover
            {
                background-color: #EEE;
            }
        }

This keeps the current hover color intact for light themes, and redefines background-, font-, and hover colors in dark mode.
The grey for the h2 can stay as-is IMO.

[532910]

could not get a dark background to appear

did you set browser.display.use_system_colors = true and restarted firefox?

[frankrolf]

I did not, and even when I do – it does not change a thing (except darkening the text on the ribbon). So I take it that it’s safer to just specify the color directly.

[532910]

Still not fixed.

[frankrolf]

You’ll find out here as soon as it is!

[pauldhunt]

@532910 can you confirm the issue is now resolved? thanks.

[532910]

Only for sans and code. Serif still looks the same.

[frankrolf]

The specimen for Source Serif will change completely in the next few weeks, so I did decide not to update the old CSS there.
Thanks for pointing out the issue!

[532910]

Thank you for resolving!