Skip to content

Commit

Permalink
Refactor test.py and test_workflow package to use common packages (op…
Browse files Browse the repository at this point in the history
…ensearch-project#186)

Move git_repository from build_workflow into a new "git" package and update build.py and test.py to use the new location.

Remove the duplicate GitRepository from test_workflow.

Change test.py to use the manifests and git packages. Move bundle_manifest to the manifests package.

Rename integ_test.py to integ_test_suite.py.

Signed-off-by: Cameron Skinner <camerski@amazon.com>
  • Loading branch information
camerski committed Aug 12, 2021
1 parent 2d5e9c7 commit 90bce4a
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 39 deletions.
2 changes: 1 addition & 1 deletion bundle-workflow/python/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
from manifests.input_manifest import InputManifest
from build_workflow.build_recorder import BuildRecorder
from build_workflow.builder import Builder
from build_workflow.git_repository import GitRepository
from paths.script_finder import ScriptFinder
from git.git_repository import GitRepository

parser = argparse.ArgumentParser(description = "Build an OpenSearch Bundle")
parser.add_argument('manifest', type = argparse.FileType('r'), help="Manifest file.")
Expand Down
12 changes: 6 additions & 6 deletions bundle-workflow/python/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
import tempfile
import argparse
from manifests.bundle_manifest import BundleManifest
from git.git_repository import GitRepository
from test_workflow.test_cluster import LocalTestCluster
from test_workflow.git import GitRepository
from test_workflow.integ_test import IntegTestSuite
from test_workflow.integ_test_suite import IntegTestSuite

parser = argparse.ArgumentParser(description = "Test an OpenSearch Bundle")
parser.add_argument('manifest', type = argparse.FileType('r'), help="Manifest file.")
Expand All @@ -21,10 +21,10 @@
cluster = LocalTestCluster(manifest.bundle_location)

# For each component, check out the git repo and run `integtest.sh`
for component in manifest.components():
print(component.name())
repo = GitRepository(component.repository_url(), component.commit_id())
test_suite = IntegTestSuite(component.name(), repo)
for component in manifest.components:
print(component.name)
repo = GitRepository(component.repository_url, component.commit_id)
test_suite = IntegTestSuite(component.name, repo)
test_suite.execute(cluster)

cluster.destroy()
Expand Down
19 changes: 0 additions & 19 deletions bundle-workflow/python/test_workflow/git.py

This file was deleted.

13 changes: 0 additions & 13 deletions bundle-workflow/python/test_workflow/integ_test.py

This file was deleted.

14 changes: 14 additions & 0 deletions bundle-workflow/python/test_workflow/integ_test_suite.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import os

class IntegTestSuite:
def __init__(self, name, repo):
self.name = name
self.repo = repo

def execute(self, cluster):
script = self.repo.dir.name + "/integtest.sh"
if (os.path.exists(script)):
print(f'sh integtest.sh -b {cluster.endpoint()} -p {cluster.port()}')
# repo.execute(f'sh integtest.sh -b {cluster.endpoint()} -p {cluster.port()}')
else:
print(f'{script} does not exist. Skipping integ tests for {self.name}')

0 comments on commit 90bce4a

Please sign in to comment.