Move git_repository into its own Python package and update build.py and test.py to use the new location. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camerski
force-pushed
the
test-workflow-refactor
branch
2 times, most recently
from
0d6038d
to
6714577
Compare
dblock
approved these changes
Aug 11, 2021
| data = yaml.safe_load(file) | ||
| return BundleManifest(data) | ||
|
|
||
| @staticmethod |
| @@ -0,0 +1,14 @@ | |||
| import os | |||
There was a problem hiding this comment.
Do we want to try and be consistent between dashes and underscores in bundle-workflow and test-workflow?
| script = self.repo.dir.name + "/integtest.sh" | ||
| if (os.path.exists(script)): | ||
| print(f'sh integtest.sh -b {cluster.endpoint()} -p {cluster.port()}') | ||
| # repo.execute(f'sh integtest.sh -b {cluster.endpoint()} -p {cluster.port()}') |
There was a problem hiding this comment.
Did you mean to leave this commented out? It wasn't in the original implementation.
There was a problem hiding this comment.
Yeah, it's stubbed out for now until we implement the setup-and-tear-down-the-test-cluster code.
|
This needs a rebase. |
camerski
force-pushed
the
test-workflow-refactor
branch
from
6714577
to
587c7d4
Compare
Move git_repository from build_workflow into a new "git" package and update build.py and test.py to use the new location. Remove the duplicate GitRepository from test_workflow. Change test.py to use the manifests and git packages. Move bundle_manifest to the manifests package. Rename integ_test.py to integ_test_suite.py. Signed-off-by: Cameron Skinner <camerski@amazon.com>
camerski
force-pushed
the
test-workflow-refactor
branch
from
587c7d4
to
3059b35
Compare
alborotogarcia
pushed a commit
to alborotogarcia/opensearch-build
that referenced
this pull request
Sep 7, 2021
…ensearch-project#186) Move git_repository from build_workflow into a new "git" package and update build.py and test.py to use the new location. Remove the duplicate GitRepository from test_workflow. Change test.py to use the manifests and git packages. Move bundle_manifest to the manifests package. Rename integ_test.py to integ_test_suite.py. Signed-off-by: Cameron Skinner <camerski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move git_repository from build_workflow into a new "git" package and update build.py and test.py to use the new location.
Remove the duplicate GitRepository from test_workflow.
Change test.py to use the manifests and git packages. Move bundle_manifest to the manifests package.
Rename integ_test.py to integ_test_suite.py.
Testing
Manually verified that
build.pyandtest.pystill work.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.