[fix]设置在web环境下才注入拦截器 #1029
Merged
[fix]设置在web环境下才注入拦截器 #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -35,6 +36,7 @@ | |||
| * And clean up Seata information after servlet method invocation in | |||
| * {@link org.springframework.web.servlet.HandlerInterceptor#afterCompletion(HttpServletRequest, HttpServletResponse, Object, Exception)} | |||
| */ | |||
| @ConditionalOnWebApplication | |||
| public class SeataHandlerInterceptor implements HandlerInterceptor { | |||
There was a problem hiding this comment.
It seems no need to add it on SeataHandlerInterceptor, on SeataHandlerInterceptorConfiguration is enough.
There was a problem hiding this comment.
似乎无需在上添加它
SeataHandlerInterceptor，就SeataHandlerInterceptorConfiguration足够了。
是的,我当时没有仔细看spring.factories文件的配置
There was a problem hiding this comment.
我不是很清楚其他容器是怎么工作的,但是这个限制是必须的至少在servlet容器下是这样的
ly641921791
reviewed
Oct 31, 2019
| @@ -23,6 +23,7 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication; | |||
There was a problem hiding this comment.
This import is not used
There was a problem hiding this comment.
It means unused, remove it.
There was a problem hiding this comment.
|
好的，我先仔细阅读下------------------ 原始邮件 ------------------
发件人: "format"<[email protected]>
发送时间: 2019年11月1日(星期五) 下午4:56
收件人: "alibaba/spring-cloud-alibaba"<[email protected]>;
抄送: "赵云兴"<[email protected]>;"Author"<[email protected]>;
主题: Re: [alibaba/spring-cloud-alibaba] [fix]设置在web环境下才注入拦截器 (#1029)
@fangjian0423 commented on this pull request.
In spring-cloud-alibaba-seata/src/main/java/com/alibaba/cloud/seata/web/SeataHandlerInterceptor.java:
@@ -23,6 +23,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
import 顺序不对。 你参看以下如何贡献(使用插件格式化一下代码): https://github.com/alibaba/spring-cloud-alibaba/wiki/%E5%A6%82%E4%BD%95%E8%B4%A1%E7%8C%AE%E4%BB%A3%E7%A0%81#%E9%85%8D%E7%BD%AE-spring-cloud-%E6%A0%87%E5%87%86%E7%9A%84%E4%BB%A3%E7%A0%81%E6%A0%BC%E5%BC%8F
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
建议撤销无效的 commit 提交，只需一个 commit 记录即可。 |
theonefx
pushed a commit
to theonefx/spring-cloud-alibaba
that referenced
this pull request
Aug 2, 2021
[fix]设置在web环境下才注入拦截器
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
com.alibaba.cloud.seata.web.SeataHandlerInterceptor和com.alibaba.cloud.seata.web.SeataHandlerInterceptorConfiguration在web环境下才工作的,但是果然环境仅依赖spring-boot-starter的时候就出现异常了或者容器用的不是servlet容器的话也是出现问题的,所以我添加了条件判断