Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]设置在web环境下才注入拦截器 #1029

Merged
merged 2 commits into from
Nov 6, 2019
Merged

[fix]设置在web环境下才注入拦截器 #1029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45479ec
[fix]设置在web环境下才注入拦截器
zhaoyunxing92 Oct 31, 2019
62ad5de
[reset]
zhaoyunxing92 Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...loud-alibaba-seata/src/main/java/com/alibaba/cloud/seata/web/SeataHandlerInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is not used

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means unused, remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经删除了

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import 顺序不对。 你参看以下如何贡献(使用插件格式化一下代码): https://github.com/alibaba/spring-cloud-alibaba/wiki/%E5%A6%82%E4%BD%95%E8%B4%A1%E7%8C%AE%E4%BB%A3%E7%A0%81#%E9%85%8D%E7%BD%AE-spring-cloud-%E6%A0%87%E5%87%86%E7%9A%84%E4%BB%A3%E7%A0%81%E6%A0%BC%E5%BC%8F

import org.springframework.util.StringUtils;
import org.springframework.web.servlet.HandlerInterceptor;

Expand All @@ -35,6 +36,7 @@
* And clean up Seata information after servlet method invocation in
* {@link org.springframework.web.servlet.HandlerInterceptor#afterCompletion(HttpServletRequest, HttpServletResponse, Object, Exception)}
*/
@ConditionalOnWebApplication
public class SeataHandlerInterceptor implements HandlerInterceptor {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems no need to add it on SeataHandlerInterceptor, on SeataHandlerInterceptorConfiguration is enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似乎无需在上添加它SeataHandlerInterceptor，就SeataHandlerInterceptorConfiguration足够了。

是的,我当时没有仔细看spring.factories文件的配置

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我不是很清楚其他容器是怎么工作的,但是这个限制是必须的至少在servlet容器下是这样的


private static final Logger log = LoggerFactory
Expand Down
2 changes: 2 additions & 0 deletions ...seata/src/main/java/com/alibaba/cloud/seata/web/SeataHandlerInterceptorConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@

package com.alibaba.cloud.seata.web;

import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
import org.springframework.web.servlet.config.annotation.InterceptorRegistry;
import org.springframework.web.servlet.config.annotation.WebMvcConfigurer;

/**
* @author xiaojing
*/
@ConditionalOnWebApplication
public class SeataHandlerInterceptorConfiguration implements WebMvcConfigurer {

@Override
Expand Down